Should i close resultset

The results otherwise are implementation-defined. The MySQL manual clearly says that? Parameter markers can be used only where data values should appear, not for SQL keywords, identifiers, and so forth.

If you use Tomcat download derbyclient. And copy the jar file to Tomcat's lib folder. Does closing Connection automatically close statement and resultset? When the connection is "too old" see below. Statement In a finally clause, after executing the query. If convenient, just before closing the Connection. ResultSet Never: just rely on closing the Statement but see below.

In a finally clause, after reading all required results. Summary of when to call close on various JDBC resources. Single ResultSet per Statement The Statement object and any ResultSet opened from it are tightly bound: there can only ever be a maximum of one open ResultSet per Statement ; closing the Statement automatically closes any open ResultSet created from it; executing SQL on a Statement also closes any previously-open ResultSet on that statement.

Closing "old" connections In principle, you should be able to open a database connection and execute as many SQL queries on it as you wish. So if you want to share a database connection over multiple queries, in practice you will generally need to do the following: close and re-create the connection when you judge that it has "expired" e. Closing any Statement will close all ResultSet s that were created by that Statement. Doesn't matter if Connection is poolable or not.

Even poolable connection has to clean before returning to the pool. Of course you might have long nested loops on the Connection creating lots of statements, then closing them is appropriate. Otherwise pooling looses its sense. I can use the Oneliner on all Queries, even if i do not have a resultSet. This is what my finally block looks like. With Java 6 form I think is better to check it is closed or not before close for example if some connection pooler evict the connection in other thread - for example some network problem - the statement and resultset state can be come closed.

My pattern is for that in older Java syntax is:. In the worst case you will get a warning in long. We are using this pattern in production with an "avarage" load simultanous user and we had no problem with it - so never see that warning message. That means they are closed automatically upon being destroyed or going out of scope. Stack Overflow for Teams — Collaborate and share knowledge with a private group. Create a free Team What is Teams? Collectives on Stack Overflow.

Learn more. Ask Question. Asked 10 years, 10 months ago. Active 1 year, 5 months ago. Viewed k times. Improve this question.

Zeemee Zeemee 9, 12 12 gold badges 48 48 silver badges 76 76 bronze badges. Add a comment. Active Oldest Votes. What you have done is perfect and very good practice. So you can't always count on connection. Parent topic: Transactions. Related concepts Transactions when auto-commit is disabled. Using auto-commit. Statement versus transaction runtime rollback.